attempt to restore support for very old pickle files #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewturk
approved these changes
Dec 22, 2017
jzuhone
approved these changes
Dec 22, 2017
cphyc
reviewed
Jan 13, 2018
| unit, lut = state[0] | ||
| try: | ||
| unit, lut = state[0] | ||
| except TypeError: |
There was a problem hiding this comment.
Maybe you should add a comment here to state that this make the very old pickle files work. Otherwise the code looks a bit cryptic.
ngoldbaum
force-pushed
the
pickle-old-format
branch
from
fa1720c
to
57d2ced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to Jason Tumlinson on the mailing list. They supplied a pickle file created with an old version of yt. Apparently on this version there was no unit lookup-table saved at all and instead just a number, which I'm interpreting as the unit name. It's possible that this will break for other old pickle files but this will at least allow yt to load the one example we know of.