New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LinearLocator, LogLocator from Visualization #1861
Conversation
@ngoldbaum Does the |
06a0c39
to
bf22699
Compare
bf22699
to
6105a63
Compare
I think this is a good change, but I'd go even further to get rid of the |
And in places where you need to use the funciton (where is that happening btw?) you could either use a lambda or just define a function outside of the |
Its happening here.
How should this be handled, if we want
|
Ah I see, we do actually need the function, it gets passed to matplotlib here: https://github.com/yt-project/yt/blob/master/yt/visualization/plot_window.py#L842-L847 So I guess we really do need both a name and a function, so it makes sense to keep the I think this is fine as-is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
PR Summary
Cleanup by removing
LinearLocator
,LogLocator
and.FieldTransform
PR Checklist
Adding Reviewers
@ngoldbaum @Xarthisius @colinmarc