[WIP] Plot window answer tests visualization.test_plotwindow.py #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-abhishek
force-pushed
the
plot-window-ans-test
branch
2 times, most recently
from
e7a1769
to
07098a0
Compare
|
@git-abhishek looks like the jenkins tests are failing now. Missed something in tests.yaml? |
|
@ngoldbaum This was getting messy, due to rebase from other branch. I will update this, once the dependent PR gets merge. |
|
Ah missed that :) |
git-abhishek
force-pushed
the
plot-window-ans-test
branch
from
07098a0
to
9c839ee
Compare
Convert unit tests to answer tests Remove test from Jenkins as answer test
git-abhishek
force-pushed
the
plot-window-ans-test
branch
from
9c839ee
to
98c897f
Compare
git-abhishek
changed the title
|
@git-abhishek Thanks for this -- we discussed and think that right now we're going to move in a different direction, but we appreciate the work you and @ngoldbaum put into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Update test cases in
test_plotwindow.pyConvert unit tests to answer tests
Remove test from Jenkins as answer test
Note: This branch is rebased from PR #1955 as
yt.visualization.tests.test_plotwindow.TEST_FLNMSisimported in
yt/visualization/tests/test_profile_plots.py.PR Checklist
Adding Reviewers
@ngoldbaum @Xarthisius @colinmarc