[bugfix] Fix incorrect weight function for cluster temperatures #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
approved these changes
Nov 27, 2018
|
Thanks @ngoldbaum |
ngoldbaum
pushed a commit
to ngoldbaum/yt
that referenced
this pull request
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yt has a derived field known as
"mazzotta_weighting"whose sole function is to provide a weight for projections which approximates temperature maps of galaxy clusters taken by Chandra or XMM-Newton. Reference is Equation 15 of http://adsabs.harvard.edu/abs/2004MNRAS.354...10M.I was looking at this field again today and noticed that it has the wrong exponent! I introduced it into yt way-back-when, and I've used it quite a bit, but I don't know who else has. In any case, here is the fix.