Cache the result of _identify_fields to improve dataset initialization speed #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This halves the runtime of scripts like in yt-project#2146 for MassiveFIRE snapshots when run on HiPerGator's lustre filesystem. On such snapshots yt used to redundantly scan the backing HDF5 files 243 times for what Datasets they contain.
|
Hi! Welcome, and thanks for opening this pull request. We have some guidelines for new pull requests, and soon you'll hear back about the results of our tests and continuous integration checks. Thank you for your contribution! |
|
Clever idea! Thanks for submitting this. It looks good to me! |
matthewturk
approved these changes
Jun 11, 2019
jzuhone
approved these changes
Jun 11, 2019
|
Hooray! Congratulations on your first merged pull request! We hope we keep seeing you around! 🎆 |
|
nice work @saethlin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on to #2146; I'm trying to cut down the overhead of yt to increase its usability in similar-looking applications (datasets >10 GB, but few operations on the dataset).
This PR halves the runtime of scripts such as mentioned in #2146 on our system, for 4-file MassiveFIRE snapshots. On such snapshots yt used to redundantly scan the backing HDF5 files 243 times for what Datasets they contain.