Test particle selections #2577
Closed
Test particle selections #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewturk
added
bug
demeshening
jzuhone
approved these changes
May 5, 2020
munkm
reviewed
May 5, 2020
|
Fido should show errors on these, but it doesn't seem to be running! |
|
So Fido's not testing these after all, so the failures won't show up. But they are real! :) |
AshKelly
reviewed
May 5, 2020
| hsml = {} | ||
| for data_file in ds.index.data_files: | ||
| for ptype, pos_arr in ds.index.io._yield_coordinates(data_file): | ||
| particles.setdefault(ptype, []).append(pos_arr) |
There was a problem hiding this comment.
I haven't come across setdefault before, nice!
AshKelly
approved these changes
May 5, 2020
brittonsmith
approved these changes
May 6, 2020
| psc = ParticleSelectionComparison(ds) | ||
|
|
||
| sp1 = ds.sphere("c", (0.1, "unitary")) | ||
| assert_equal(psc.compare_dobj_selection(sp1) , True) |
There was a problem hiding this comment.
Not necessary to change, but this could just be assert psc.compare_dobj_selection(sp1), right?
There was a problem hiding this comment.
Yes, it could -- I can't remember now why I used this.
munkm
approved these changes
May 6, 2020
|
This adds a few more failing tests and I'm working on an update to #2575 to address them. |
|
I'm going to merge this into #2575 to manage it all together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a helper function to manually test particle selections. I've also implemented it for the
snapshot_033dataset.Until #2575 goes in, this will fail. When #2575 goes in, it should pass.