Update OpenPMD test to include 'nbody' ptype #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munkm
reviewed
Jun 25, 2020
| domain_dimensions = [32, 64, 64] * np.ones_like(dss[0].domain_dimensions) | ||
| domain_width = [0.0002752, 0.0005504, 0.0005504] * np.ones_like(dss[0].domain_left_edge) | ||
|
|
||
| assert_equal(len(dss), 101) | ||
| for ds in dss: | ||
| for i in range(0, len(dss), 20): # Test only every 20th ds out of the series |
There was a problem hiding this comment.
Is the reason for one out of every 20th to speed up testing? or something else?
There was a problem hiding this comment.
Yes, speed. Since that test doesn't do anything different for an individual ds right now, there's really no point in doing it for each and everyone.
munkm
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This should fix the OpenPMD errors appearing in #2677.
Update: I sneaked in a minor cosmetic fix for Arepo, that I botched in #2677. It's only avoiding doing the same thing twice.