Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor walk_volume in volume rendering #2809

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matthewturk
Copy link
Member

PR Summary

In order to support non-Cartesian volume rendering, we need to be able to switch the volume walk algorithm on the fly. This sets up the preliminary means to do that, by turning walk_volume into a function pointer, and (similar to the smoothing kernel work) using a getter function that looks up the type of geometry and supplies the correct one.

PR Checklist

  • pass black --check yt/
  • pass isort . --check --diff
  • pass flake8 yt/
  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@cphyc
Copy link
Member

cphyc commented Aug 4, 2020

Note that this PR likely clashes with #2610, so it would be worth joining efforts!

@matthewturk
Copy link
Member Author

@cphyc !!! you're right, how did I miss that?!

@cphyc
Copy link
Member

cphyc commented Aug 4, 2020

So after a more thorough inspection, it seems these two PRs aren't clashing that much, but it would be great to disentangle the code so that we have

  • a cartesian ray caster on grid-based datasets
  • a cylindrical ray caster on grid-based datasets (this PR)
  • a cartesian ray caster on oct-based datasets (Volume rendering for octrees #2610)

organized in some clever way. I'm open to suggestions to work on #2610!

Base automatically changed from master to main January 20, 2021 15:27
@matthewturk matthewturk marked this pull request as draft May 18, 2021 19:34
@matthewturk
Copy link
Member Author

I'm converting this to draft until after 4.0 goes out so that it won't show up in my filters. It also needs to be updated with @cphyc 's suggestions and changes.

@neutrinoceros neutrinoceros added the refactor improve readability, maintainability, modularity label Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Making something better refactor improve readability, maintainability, modularity viz: volume rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants