switch internal instances of collections.OrderedDict to regular dict #3030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when the differences do not matter any more (starting from python 3.6, dict objects preserve insertion order)
neutrinoceros
added
the
refactor
neutrinoceros
commented
Jan 21, 2021
| @@ -69,7 +67,6 @@ def __init__( | |||
|
|
|||
| if fields is None: | |||
| fields = [] | |||
| fields = list(OrderedDict.fromkeys(fields)) | |||
There was a problem hiding this comment.
This may not look obvious but the current implementation here is actually doing nothing, so I went with the option of preserving behaviour rather than intent. I think the original intent was to sort the keys, in which case it should be simply reimplemented as
fields = sorted(keys)@jzuhone , do you remember this ? :)
There was a problem hiding this comment.
I think this is fine. I also think that someone came in here and did this later, because I don't recognize the code to be honest.
There was a problem hiding this comment.
Cool, thanks for your prompt answer
cphyc
approved these changes
Jan 22, 2021
jzuhone
approved these changes
Jan 22, 2021
| @@ -69,7 +67,6 @@ def __init__( | |||
|
|
|||
| if fields is None: | |||
| fields = [] | |||
| fields = list(OrderedDict.fromkeys(fields)) | |||
There was a problem hiding this comment.
I think this is fine. I also think that someone came in here and did this later, because I don't recognize the code to be honest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
…when the differences do not matter any more: starting from Python 3.6, normal dict objects preserve insertion order.
I was originally aiming at replacing all ordereddict by normal dict but I left every user-facing one untouched because comparison is still different between the two classes, so I don't mean to cause bugs downwards where OrderedDict is possibly still relevant.