Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matplotlib canonical link #3080

Merged
merged 2 commits into from Feb 22, 2021
Merged

Conversation

jklymak
Copy link
Contributor

@jklymak jklymak commented Feb 17, 2021

@welcome
Copy link

welcome bot commented Feb 17, 2021

Hi! Welcome, and thanks for opening this pull request. We have some guidelines for new pull requests, and soon you'll hear back about the results of our tests and continuous integration checks. Thank you for your contribution!

@neutrinoceros
Copy link
Member

Hi @jklymak , thanks for fixing this. I note that we have 20 other occurrences of the url https://matplotlib.org/ in the repo ( git grep https://matplotlib.org/), some are pointing to specific versions of matplotlib but the majority isn't. Should those be changed as well ?

@neutrinoceros neutrinoceros added the infrastructure Related to CI, versioning, websites, organizational issues, etc label Feb 17, 2021
@jklymak
Copy link
Contributor Author

jklymak commented Feb 17, 2021

Up to you - the old links should work via html refresh redirect - but the intersphinx link checker doesn't like the redirects and complains, so I was proactively pinging a few projects. Thanks!

@neutrinoceros
Copy link
Member

Wrote a cute one-line to perform this sweeping change, can you run it ? or otherwise allow me to push to your branch ?

$ git ls-files --recurse-submodules | xargs egrep "https://matplotlib.org/[^3]" | cut -d ':' -f 1 | uniq | xargs sed -i -e "s|https://matplotlib.org|https://matplotlib.org/stable|g"

@jklymak
Copy link
Contributor Author

jklymak commented Feb 17, 2021

Feel free to push to branch or close this and start fresh. I just made this change directly on GitHub and don't have yt downloaded locally (I'd lose my oceanographer license 😉 )

@matthewturk
Copy link
Member

@jklymak we really really want to talk a lot more about oceanography! I really hope the two are not in conflict. :)

@neutrinoceros
Copy link
Member

pushed :)

@neutrinoceros
Copy link
Member

I think I reverted all the 404 errors, thanks @cphyc

@Xarthisius
Copy link
Member

@yt-fido test this please

@cphyc
Copy link
Member

cphyc commented Feb 17, 2021

I think I tested all URLs and they're all non-404!

@neutrinoceros neutrinoceros merged commit 6d380ae into yt-project:main Feb 22, 2021
@welcome
Copy link

welcome bot commented Feb 22, 2021

Hooray! Congratulations on your first merged pull request! We hope we keep seeing you around! 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to CI, versioning, websites, organizational issues, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants