New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update matplotlib canonical link #3080
Conversation
Hi! Welcome, and thanks for opening this pull request. We have some guidelines for new pull requests, and soon you'll hear back about the results of our tests and continuous integration checks. Thank you for your contribution! |
Hi @jklymak , thanks for fixing this. I note that we have 20 other occurrences of the url |
Up to you - the old links should work via html refresh redirect - but the intersphinx link checker doesn't like the redirects and complains, so I was proactively pinging a few projects. Thanks! |
Wrote a cute one-line to perform this sweeping change, can you run it ? or otherwise allow me to push to your branch ? $ git ls-files --recurse-submodules | xargs egrep "https://matplotlib.org/[^3]" | cut -d ':' -f 1 | uniq | xargs sed -i -e "s|https://matplotlib.org|https://matplotlib.org/stable|g" |
Feel free to push to branch or close this and start fresh. I just made this change directly on GitHub and don't have yt downloaded locally (I'd lose my oceanographer license 😉 ) |
@jklymak we really really want to talk a lot more about oceanography! I really hope the two are not in conflict. :) |
pushed :) |
3e47951
to
fda343b
Compare
fda343b
to
22d8034
Compare
I think I reverted all the 404 errors, thanks @cphyc |
@yt-fido test this please |
I think I tested all URLs and they're all non-404! |
Hooray! Congratulations on your first merged pull request! We hope we keep seeing you around! 🎆 |
Please see: https://discourse.matplotlib.org/t/canonical-documentation-have-moved/21863