[bugfix] generate_smoothing_length expects 64-bit positions #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzuhone
changed the title
|
@yt-fido test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In PR #2645 we added the capability to generate smoothing lengths for a Gadget HDF5 dataset that didn't have one. It turns out the example I used had 64-bit particle positions (which is not typical, Gadget datasets usually have 32-bit positions), and the
generate_smoothing_lengthfunction expects 64-bit positions.There may be a better way of handling this (with a fused type or something) but this is a quick fix. Note that we have to cast the
positionsarray upon entry into thegenerate_smoothing_lengthfunction so that the original array retains its original type.