BUG: add support for setting up derived fields from lambdas #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
bug
api-consistency
matthewturk
approved these changes
Jul 17, 2021
| @@ -250,10 +250,7 @@ def get_dependencies(self, *args, **kwargs): | |||
| This returns a list of names of fields that this field depends on. | |||
| """ | |||
| e = FieldDetector(*args, **kwargs) | |||
| if self._function.__name__ == "<lambda>": | |||
There was a problem hiding this comment.
So I've done some thinking, and I think this comes from waaaay back in the day when we may have used lambdas to represent on-disk fields.
|
Thanks Matt, now I'm much more confident in calling this a plain bug fix :) |
jzuhone
approved these changes
Jul 18, 2021
|
@jzuhone , @matthewturk , anyone in particular that you would like to take a look a this too or is it good for merging ? |
42 tasks
|
@meeseeksdev backport to yt-4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Oct 15, 2021
…fields from lambdas
neutrinoceros
added a commit
that referenced
this pull request
Oct 16, 2021
…0-on-yt-4.0.x Backport PR #3440 on branch yt-4.0.x (FIX: add support for setting up derived fields from lambdas)
neutrinoceros
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is an alternative fix to #3434, and supersedes #3438.
The solution tried here was suggested by @forrestglines. It's not clear to me why the problematic check was ever necessary but it's
been here for 8yrs so my hypothesis is that it may have become inappropriate in Python 3 ?
I'm doubting this would break anything since there doesn't seem to be a single use case of lambdas in derived fields in the code base/docs/tests. On the other hand, the test I'm adding here fails on the main branch (as reported in #3434).