fix combining FITS images #3456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
requested changes
Jul 27, 2021
jzuhone
force-pushed
the
fix_join_fits_images
branch
from
7cbef2c
to
45b2e63
Compare
neutrinoceros
approved these changes
Jul 28, 2021
42 tasks
|
@meeseeksdev backport to yt-4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Oct 15, 2021
neutrinoceros
added a commit
that referenced
this pull request
Oct 16, 2021
…6-on-yt-4.0.x Backport PR #3456 on branch yt-4.0.x (fix combining FITS images)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed as the PrimaryHDU
PR Summary
The
combine_imagesmethod of theFITSImageDataclass allows one to combine multiple images into one, but a FITS file is only valid if the first image is aPrimaryHDU. The previous implementation, when stitching multipleFITSImageDatainstances together, was attempting to create multiplePrimaryHDUinstances (the first image from each instance). This PR fixes it and adds a single line to theFITSImageDatatests which ensure that this functionality works correctly.PR Checklist