-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: loosen header matching for Athena vtk files to allow compatibility with single variable 'vtk outputs' #3490
ENH: loosen header matching for Athena vtk files to allow compatibility with single variable 'vtk outputs' #3490
Conversation
…ty with single variable 'vtk outputs'
I assume that the answer test failures are unrelated? |
Yes, they are the exact same that we've been seeing on daily runs for a couple days. See for instance today's logs https://tests.yt-project.org/job/yt_py38_latest_deps/346/ |
@meeseeksdev backport to yt-4.0.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove If these instruction are inaccurate, feel free to suggest an improvement. |
@meeseeksdev backport to yt-4.0.x |
…tk files to allow compatibility with single variable 'vtk outputs'
…0-on-yt-4.0.x Backport PR #3490 on branch yt-4.0.x (ENH: loosen header matching for Athena vtk files to allow compatibility with single variable 'vtk outputs')
PR Summary
this is a hotfix to #3424 that was merged slighlty before I could integrate this change required by @jzuhone