-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: fix two bugs with symlog colorbar ticks for matplotlib 3.5 #3556
Conversation
Ah, this is one more place we need versioned branches to support various versions of MPL apparently |
cfe098f
to
936c323
Compare
switching to draft while we're stabilizing the auto backporting system |
@@ -285,13 +285,18 @@ def _init_image(self, data, cbnorm, cblinthresh, cmap, extent, aspect): | |||
) | |||
) | |||
elif zmax <= 0.0: | |||
if MPL_VERSION >= Version("3.5.0b"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you document why this fixes the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually it's pretty hard to follow matplotlib's dev. I know they've been doing drastic refactors to the colobar objects, and I could point to the exact PRs where that happened, but their line changes are very large (+1k/-1k typically).
My guess is that this "offset" is actually an off-by-one error that slipped into yt because it was compensated by an equivalent mistake in matplotlib, which is why we need to keep it for versions older than 3.5, hence this bizarre construct. Anyway I tried to just remove this offset completely but unfortunately it broke for Matplotlib 3.4
Should I use some of this comment and bundle it with the code ?
@cphyc it seems you enabled auto-merging here but didn't formally approve (which is required for auto-merge). |
@meeseeksdev backport to yt-4.0.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove If these instruction are inaccurate, feel free to suggest an improvement. |
…icks BUG: fix two bugs with symlog colorbar ticks for matplotlib 3.5
PR Summary
fix #3554
fix #3560