BLD: Fix build on i386 #3606
Merged
BLD: Fix build on i386 #3606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 tasks
|
added to #3555 🎉 |
matthewturk
approved these changes
Oct 20, 2021
|
@matthewturk do you want to require a second review here ? I don't know if I'd be able to test this myself, but I'm tempted to merge this with your single approval. |
|
@meeseeksdev backport to yt-4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Nov 6, 2021
matthewturk
added a commit
that referenced
this pull request
Nov 10, 2021
…6-on-yt-4.0.x Backport PR #3606 on branch yt-4.0.x (BLD: Fix build on i386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes ambiguity in the ewah C utils on i386 platforms. In particular, this PR explicitely defines UWORD as a 32bit unsigned integer on i386 and as a 64bit unsigned integer on x86-64.
PR Summary
This fixes #3477.