-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gdf] dimensionality doesn't imply which dimension is reduced #3630
Conversation
Well played ! Notes on the output graph:
These are points I'd like addressed along with the original issue you were pointing out: there's a demand for supporting this operation but the current solution is a little hacky as well as undocumented. I'm writing this note on my phone mostly so I can open an issue from it later. I'm not asking for changes to the present PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I did a little research on the data format and all I could find so far was a repo of yours
https://github.com/Xarthisius/fgdfio
which gives out a link to the format spec, which is unfortunately broken
https://bitbucket.org/yt_analysis/grid_data_format/
I confirm I can reproduce the error and that the patch fixes it, so I could just merge this, but out of curiosity, do you have any resource on this data format that I could refer to ?
|
@meeseeksdev backport to yt-4.0.x |
… dimension is reduced
…0-on-yt-4.0.x Backport PR #3630 on branch yt-4.0.x ([gdf] dimensionality doesn't imply which dimension is reduced)
Root cause that I was hitting this is that
b"piernik" != "piernik"
... However, I came to a conclusion that this clause is wrong for any GDF output, not just that one particular flavor. GDF already implies that RE/LE is a 3-element array, so there's no point in making assumptions about 1) which dimension is reduced or 2) what the value of dds in that dimension should be.Using script from #3629:
now I get: