Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add an exhaustive list of deprecations to the yt4differences page #3665

Merged

Conversation

neutrinoceros
Copy link
Member

PR Summary

Fix #3451
This should be backported to the 4.0.x branch

@neutrinoceros neutrinoceros added docs deprecation deprecate features or remove deprecated ones labels Nov 12, 2021
@neutrinoceros neutrinoceros added this to the 4.0.2 milestone Nov 12, 2021
@matthewturk matthewturk added the backport-yt-4.0.x on-merge: backport to yt-4.0.x label Nov 12, 2021
matthewturk
matthewturk previously approved these changes Nov 12, 2021
doc/source/yt4differences.rst Outdated Show resolved Hide resolved
doc/source/yt4differences.rst Outdated Show resolved Hide resolved
doc/source/yt4differences.rst Outdated Show resolved Hide resolved
doc/source/yt4differences.rst Outdated Show resolved Hide resolved
doc/source/yt4differences.rst Outdated Show resolved Hide resolved
doc/source/yt4differences.rst Outdated Show resolved Hide resolved
doc/source/yt4differences.rst Outdated Show resolved Hide resolved
doc/source/yt4differences.rst Outdated Show resolved Hide resolved
doc/source/yt4differences.rst Outdated Show resolved Hide resolved
doc/source/yt4differences.rst Outdated Show resolved Hide resolved
chummels
chummels previously approved these changes Nov 12, 2021
Copy link
Member

@chummels chummels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is terrific! Thank you for doing this, @neutrinoceros !

doc/source/yt4differences.rst Outdated Show resolved Hide resolved
Co-authored-by: Kacper Kowalik <xarthisius.kk@gmail.com>
@neutrinoceros
Copy link
Member Author

Thanks a lot @Xarthisius for your numerous corrections, it's much better now !

@neutrinoceros
Copy link
Member Author

(@matthewturk here again, auto-merge won't work for docs-only PRs)

Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Merge whenever it's green, I say.

@neutrinoceros
Copy link
Member Author

it is green already :)
It's only shown as "🟡" because auto-merge is waiting for the answer test job, which will not trigger because it's a doc-only patch

@neutrinoceros
Copy link
Member Author

Seems like I can't even regular-merge while auto-merge is setup this way

@matthewturk matthewturk merged commit 563c4b9 into yt-project:main Nov 15, 2021
meeseeksmachine pushed a commit to meeseeksmachine/yt that referenced this pull request Nov 15, 2021
@neutrinoceros neutrinoceros deleted the doc_missing_depre_section_4.0 branch November 15, 2021 10:45
matthewturk added a commit that referenced this pull request Nov 17, 2021
…5-on-yt-4.0.x

Backport PR #3665 on branch yt-4.0.x (DOC: add an exhaustive list of deprecations to the yt4differences page)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-yt-4.0.x on-merge: backport to yt-4.0.x deprecation deprecate features or remove deprecated ones docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: yt4 differences missing deprecation section
4 participants