MNT: matplotlib 3.5 compat #3670

neutrinoceros · 2021-11-16T08:48:40Z

PR Summary

I'm fixing a couple error messages here as an excuse to trigger CI so that I can update the answer store.
This PR will be a blocker unless it turns out that no update is needed.

goal ? fix #3558
why now ? matplotlib 3.5.0 just came out. I'm hoping that my work with the release candidate was enough to make this update pretty transparent
but I still expect we're going to see some small changes in our test images, at a level that will bother CI but not humans 🤞🏻

…d produce new images with matpltolib 3.5

neutrinoceros · 2021-11-16T09:38:59Z

As expected we're only getting insignificant differences, and only 2 of them I might add

neutrinoceros · 2021-11-16T17:11:24Z

Updates for the answer store are here:
yt-project/answer-store#27

regarding Jenkins, I'll wait for allowance to bump images everywhere needed. From what I've seen, every difference we're getting is equally insignificant so it shouldn't be controversial.

neutrinoceros · 2021-11-17T07:42:12Z

adding "bug" label to satisfy the Mergeable bot.

I note that the prediction I gave in #3558 came true: symlog colorbars suddenly have minor ticks again, hurray !

neutrinoceros · 2021-11-17T12:29:17Z

Added a minimal patch to fix #3673 while I'm at it

neutrinoceros · 2021-11-17T12:39:53Z

yt/visualization/base_plot_types.py

@@ -337,8 +336,7 @@ def _init_image(self, data, cbnorm, cblinthresh, cmap, extent, aspect):
            self.cb.set_ticks(yticks)
        else:
            self.cb = self.figure.colorbar(self.image, self.cax)
-        for which in ["major", "minor"]:
-            self.cax.tick_params(which=which, axis="y", direction="in")
+        self.cax.tick_params(which="both", axis="y", direction="in")


I guess the explicit loop was necessary with old versions of matplotlib but it's not needed for the current oldest supported version (2.2.0)
see https://matplotlib.org/2.2.0/api/_as_gen/matplotlib.axes.Axes.tick_params.html?highlight=tick_params#matplotlib.axes.Axes.tick_params

OK, makes sense.

- force inwards ticks for colorbar in PhasePlot - simplify calls to tick_params using modern matplotlib api

matthewturk · 2021-11-17T13:29:36Z

So if I'm reading it right, now our answer tests mandate matplotlib 3.5, right?

matthewturk

I don't see any reason this can't go in other than the minor comments about CI.

matthewturk · 2021-11-17T13:30:06Z

yt/visualization/base_plot_types.py

@@ -337,8 +336,7 @@ def _init_image(self, data, cbnorm, cblinthresh, cmap, extent, aspect):
            self.cb.set_ticks(yticks)
        else:
            self.cb = self.figure.colorbar(self.image, self.cax)
-        for which in ["major", "minor"]:
-            self.cax.tick_params(which=which, axis="y", direction="in")
+        self.cax.tick_params(which="both", axis="y", direction="in")


OK, makes sense.

neutrinoceros · 2021-11-17T13:31:31Z

So if I'm reading it right, now our answer tests mandate matplotlib 3.5, right?

not explicitly, but answer testing is always run against the latest available version of matplotlib, so it's ran against 3.5 since it came out yesterday

matthewturk · 2021-11-17T13:32:19Z

Once we get the new answers in and respawn testing this should go in.

neutrinoceros · 2021-11-17T13:32:50Z

Cool, I'm bumping baselines for Jenkins then.

neutrinoceros · 2021-11-17T13:36:04Z

We need to merge yt-project/answer-store#27 as well so I can update here

neutrinoceros · 2021-11-17T14:25:25Z

I forgot to bump one of the references, forced pushed. Now I expect images tests on Jenkins to pass

neutrinoceros · 2021-11-19T06:26:42Z

removing the "backport" label since its purpose is now covered by having the PR triaged in the 4.0.2 milestone already.

lumberbot-app · 2021-11-19T14:56:28Z

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

git checkout yt-4.0.x
git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -m1 62b645889ae0eb27171ef310dae03069e4181e46

You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #3670: MNT: matplotlib 3.5 compat'

Push to a named branch:

git push YOURFORK yt-4.0.x:auto-backport-of-pr-3670-on-yt-4.0.x

Create a PR against branch yt-4.0.x, I would have named this PR:

"Backport PR #3670 on branch yt-4.0.x (MNT: matplotlib 3.5 compat)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

neutrinoceros · 2021-11-19T15:08:54Z

Ah, turns out this can't be back ported (not automatically OR manually) unless we backport #3441 as well. This is because local_pw tests were modified when switching to cmyt as a dependency. Now it seems to me that there are two ways we can keep CI green on the backport branch:

backport ENH: migrate native colormaps out of yt and use cmyt as a dependency (YTEP-0040) #3441 as well as this
exclude matplotlib 3.5 for the backport branch, which would be a pity since several bug fixes are intented to improve compatibility with it...

After writing this I don't think there's a way around it so I'll just manually backport #3441 + this, hopefully this is acceptable.

MNT: matplotlib 3.5 compat

fix a couple inappropriate error types, as an excuse to trigger CI an…

860ce98

…d produce new images with matpltolib 3.5

neutrinoceros added blocker Highest priority level tests: running tests Issues with the test setup labels Nov 16, 2021

neutrinoceros mentioned this pull request Nov 16, 2021

Updates for matplotlib 3.5 yt-project/answer-store#27

Merged

neutrinoceros modified the milestone: 4.0.2 Nov 16, 2021

neutrinoceros added the backport-yt-4.0.x on-merge: backport to yt-4.0.x label Nov 16, 2021

neutrinoceros mentioned this pull request Nov 16, 2021

MNT: add explicit support for Python 3.10 on UNIX #3543

Merged

2 tasks

neutrinoceros mentioned this pull request Nov 16, 2021

BLD: Explicitly cast np.argsort() result to target data type #3671

Merged

2 tasks

neutrinoceros added the bug label Nov 17, 2021

neutrinoceros mentioned this pull request Nov 17, 2021

BUG: ticks in phase plots colobar are not set inwards #3673

Closed

neutrinoceros linked an issue Nov 17, 2021 that may be closed by this pull request

BUG: ticks in phase plots colobar are not set inwards #3673

Closed

neutrinoceros added the viz: 2D label Nov 17, 2021

neutrinoceros commented Nov 17, 2021

View reviewed changes

BUG: fix style inconsistency between PhasePlot and SlicePlot

c8fb880

- force inwards ticks for colorbar in PhasePlot - simplify calls to tick_params using modern matplotlib api

neutrinoceros force-pushed the mpl_3.5_updates branch from 89e0de9 to c8fb880 Compare November 17, 2021 12:42

neutrinoceros mentioned this pull request Nov 17, 2021

BLD: require setuptools>=59 (partial migration out of distutils) #3674

Closed

matthewturk previously approved these changes Nov 17, 2021

View reviewed changes

matthewturk enabled auto-merge November 17, 2021 13:32

neutrinoceros dismissed matthewturk’s stale review via 68c719f November 17, 2021 13:35

bump image test baseline for matplotlib 3.5

f55bcd9

neutrinoceros force-pushed the mpl_3.5_updates branch from 68c719f to f55bcd9 Compare November 17, 2021 14:24

bump answer store for Matplotlib 3.5

4efa7e5

neutrinoceros removed the backport-yt-4.0.x on-merge: backport to yt-4.0.x label Nov 19, 2021

cphyc approved these changes Nov 19, 2021

View reviewed changes

matthewturk merged commit 62b6458 into yt-project:main Nov 19, 2021

lumberbot-app bot added the Still Needs Manual Backport label Nov 19, 2021

neutrinoceros deleted the mpl_3.5_updates branch November 19, 2021 14:58

neutrinoceros pushed a commit to neutrinoceros/yt that referenced this pull request Nov 19, 2021

Merge pull request yt-project#3670 from neutrinoceros/mpl_3.5_updates

c4a6a90

MNT: matplotlib 3.5 compat

neutrinoceros mentioned this pull request Nov 19, 2021

Backports mpl compat to yt-4.0.x #3678

Merged

neutrinoceros removed the Still Needs Manual Backport label Dec 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MNT: matplotlib 3.5 compat #3670

MNT: matplotlib 3.5 compat #3670

neutrinoceros commented Nov 16, 2021

neutrinoceros commented Nov 16, 2021

neutrinoceros commented Nov 16, 2021

neutrinoceros commented Nov 17, 2021

neutrinoceros commented Nov 17, 2021

neutrinoceros Nov 17, 2021

matthewturk Nov 17, 2021

matthewturk commented Nov 17, 2021

matthewturk left a comment

matthewturk Nov 17, 2021

neutrinoceros commented Nov 17, 2021

matthewturk commented Nov 17, 2021

neutrinoceros commented Nov 17, 2021

neutrinoceros commented Nov 17, 2021

neutrinoceros commented Nov 17, 2021

neutrinoceros commented Nov 19, 2021

lumberbot-app bot commented Nov 19, 2021

neutrinoceros commented Nov 19, 2021

MNT: matplotlib 3.5 compat #3670

MNT: matplotlib 3.5 compat #3670

Conversation

neutrinoceros commented Nov 16, 2021

PR Summary

neutrinoceros commented Nov 16, 2021

neutrinoceros commented Nov 16, 2021

neutrinoceros commented Nov 17, 2021

neutrinoceros commented Nov 17, 2021

neutrinoceros Nov 17, 2021

Choose a reason for hiding this comment

matthewturk Nov 17, 2021

Choose a reason for hiding this comment

matthewturk commented Nov 17, 2021

matthewturk left a comment

Choose a reason for hiding this comment

matthewturk Nov 17, 2021

Choose a reason for hiding this comment

neutrinoceros commented Nov 17, 2021

matthewturk commented Nov 17, 2021

neutrinoceros commented Nov 17, 2021

neutrinoceros commented Nov 17, 2021

neutrinoceros commented Nov 17, 2021

neutrinoceros commented Nov 19, 2021

lumberbot-app bot commented Nov 19, 2021

neutrinoceros commented Nov 19, 2021