ENH: make plot callbacks with 'factor' argument accept 2-tuples to distinguish x/y resolutions

[neutrinoceros]

PR Summary

Fix #3685

import yt

ds = yt.load_sample("IsolatedGalaxy")

plot = yt.SlicePlot(ds, "z", "density", width=(0.04, 0.01))

plot.annotate_quiver(
    "velocity_x",
    "velocity_y",
    factor=(16, 64), # new !
    normalize=True,
    plot_args={"color": "white"},
)

plot.save("/tmp/factor.png")

[matthewturk]

I think we're mostly OK here but I want to verify from @neutrinoceros that it's in the right x,y order, and ask why it has to be an integer.

[matthewturk]

Why does it have to be an integer?

[neutrinoceros]

@matthewturk this is why I'm checking for integers. While floats are mathematically compatible here, ultimately we're counting pixels, so I think that passing a float signals either a misconception on the user side or a bug

[matthewturk]

I'm not sure I agree with that. We're specifically talking about the factor for changing the resolution; there is a substantial use case possible (even if not necessarily typically desirable) for values betweeen 0 and 1.

[neutrinoceros]

would that work, really ? Running this on the main branch

import yt

ds = yt.load_sample("IsolatedGalaxy")

plot = yt.SlicePlot(ds, "z", "density", width=(0.04, 0.01))

plot.annotate_quiver(
    "velocity_x",
    "velocity_y",
    factor=0.5,
    normalize=True,
    plot_args={"color": "white"},
)

plot.save("/tmp/factor.png")

I'm getting

YTPlotCallbackError: annotate_quiver callback failed

[matthewturk]

Alright! Let's consider that addressed then.

[neutrinoceros]

I want to verify from @neutrinoceros that it's in the right x,y order

Sorry I don't understand what I need to justify/explain here

[matthewturk]

@neutrinoceros I mean, just say you checked that the order of x and y factors versus the image make sense, since we often do some strange transposition etc.

[neutrinoceros]

It works in cases that I've tried, but I'm not sure how to test is extensively.

[neutrinoceros]

Alright guys thank you for reviewing this early but I need to solve a conflict so I expect your approvals to go away after that. I'll remove the draft status when everything is green again :)

[neutrinoceros]

well actually we could also use auto-merge so no-one has to wait... removing the draft status now

[neutrinoceros]

@yt-fido test this please

[neutrinoceros]

I pushed again to resolve a conflict. Auto merge is still enabled but I lost aprovals here. Could anyone approve (again) ?