BUG: fix a regression in SlicePlot and ProjectionPlot APIs #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
bug
api-consistency
neutrinoceros
changed the title
neutrinoceros
force-pushed
the
fixup_normalplot_api
branch
3 times, most recently
from
f66647a
to
5a41f9b
Compare
neutrinoceros
force-pushed
the
fixup_normalplot_api
branch
2 times, most recently
from
aec4000
to
a88f1be
Compare
neutrinoceros
force-pushed
the
fixup_normalplot_api
branch
from
a88f1be
to
e51833d
Compare
neutrinoceros
force-pushed
the
fixup_normalplot_api
branch
from
e51833d
to
ec232fe
Compare
matthewturk
approved these changes
Dec 28, 2021
This was referenced Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
fix #3722
Opening as a draft to make sure that CI stays green with existing tests, but I want to add the test cases from #3722 + tests for deprecations too
Note that the regression fixed here is on the main branch only so this doesn't need backporting.