Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: fix a bug in masking invalid values in line integral convolution callback #3739

Merged
merged 2 commits into from
Jan 11, 2022
Merged

BUG: fix a bug in masking invalid values in line integral convolution callback #3739

merged 2 commits into from
Jan 11, 2022

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Dec 29, 2021 •
edited
Loading

PR Summary

fix #3738

after

@neutrinoceros neutrinoceros added bug viz: 2D backport-yt-4.0.x on-merge: backport to yt-4.0.x labels Dec 29, 2021
@neutrinoceros neutrinoceros marked this pull request as draft December 29, 2021 22:26
@neutrinoceros
Copy link
Member Author

neutrinoceros commented Dec 29, 2021 •
edited
Loading

making this a draft for two reasons:

  • I'm going to check wether other space-filling callback need a similar patch (edit: not that I can tell)
  • CI is currently unstable for different reasons so I'll be able to signal this is ready when things stabilise and I remove the draft status

@neutrinoceros
Copy link
Member Author

while I'm at it I also fixed reproducibility of these LIC plots

@neutrinoceros neutrinoceros marked this pull request as ready for review January 10, 2022 13:13
@neutrinoceros neutrinoceros removed the backport-yt-4.0.x on-merge: backport to yt-4.0.x label Jan 10, 2022
matthewturk
matthewturk reviewed Jan 11, 2022
View reviewed changes
yt/visualization/plot_modifications.py
@@ -3104,6 +3105,10 @@ def __call__(self, plot):
lic_data = lic_data / lic_data.max()
lic_data_clip = np.clip(lic_data, self.lim[0], self.lim[1])

mask = ~(np.isfinite(pixX) & np.isfinite(pixY))
lic_data[mask] = np.nan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional for future changes:

np.putmask(lic_data, mask, np.nan)
np.putmask(lic_data_clip, mask, np.nan)

@matthewturk matthewturk merged commit 9bc35d4 into yt-project:main Jan 11, 2022
@neutrinoceros neutrinoceros deleted the lic_polar_fix branch January 11, 2022 15:41
neutrinoceros pushed a commit to neutrinoceros/yt that referenced this pull request Feb 7, 2022
@matthewturk @neutrinoceros
Merge pull request yt-project#3739 from neutrinoceros/lic_polar_fix
f433dd5 
BUG: fix a bug in masking invalid values in line integral convolution callback
@neutrinoceros neutrinoceros mentioned this pull request Feb 7, 2022
Merged
@neutrinoceros neutrinoceros added this to the 4.0.3 milestone Apr 19, 2022
@neutrinoceros neutrinoceros mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
bug viz: 2D
Projects
None yet
Milestone
4.0.3
Development

Successfully merging this pull request may close these issues.

BUG: improper masking in line integral convolution callback
2 participants
@neutrinoceros @matthewturk