Fix bug in bitmap index for particle datasets #3788
Conversation
…he total number of refined cells for a coarse cell instead of the number of new refined cells
|
Hi! Welcome, and thanks for opening this pull request. We have some guidelines for new pull requests, and soon you'll hear back about the results of our tests and continuous integration checks. Thank you for your contribution! |
There was a problem hiding this comment.
I have tested and verified, and it works! Plus the explanation makes sense. Thank you, @langmm!
|
Before this gets merged, let's set up a milestone for 4.0.3 and add this to it? |
matthewturk
added
bug
demeshening
|
@jzuhone I'll leave this to you to hit the button on -- I've added the milestone and it should auto-backport. |
|
I agree, works great! |
|
@matthewturk @langmm thanks for your help in tracking this down, it's a big help. once the tests pass I will merge. |
|
Hooray! Congratulations on your first merged pull request! We hope we keep seeing you around! 🎆 |
…8-on-yt-4.0.x Backport PR #3788 on branch yt-4.0.x (Fix bug in bitmap index for particle datasets)
PR Summary
This PR fixes a bug where __fill_refined_ranges in ParticleBitmap was returning the total number of refined cells for a coarse cell instead of the number of new refined cells. This bug caused coarse cells to be marked as fully refined on subsequent passes and so they were not actually refined and resulted in some files not being identified as selected, particularly for selectors that rely on the refined index (e.g. slice selector).
This fixes #3672
PR Checklist