DOC: update contribution guidelines #3813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
found the document I had in mind: https://github.com/yt-project/governance/blob/7e8793735f067f2681966ea0e848d542a813b1aa/source/voting.rst |
|
This is good but to be honest, I sometimes worry that the terseness of our language is off-putting. |
matthewturk
previously approved these changes
Feb 17, 2022
Co-authored-by: Matthew Turk <matthewturk@gmail.com>
matthewturk
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is aimed at fixing #2554
what's missing still is a link to the document where we define the number of reviews needed for all kinds of PRs, because I couldn't find it back.
Keeping this as a draft until then