Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: fix a regression where calling annotate_timestamp on a plot from a dataset with code units would crash #3870

Merged
merged 1 commit into from
Mar 30, 2022
Merged

BUG: fix a regression where calling annotate_timestamp on a plot from a dataset with code units would crash #3870

merged 1 commit into from
Mar 30, 2022

Conversation

neutrinoceros
Copy link
Member

PR Summary

Fix #3869
Turns out that the custom error reraising introduced in #2728 is apparently not necessary since #3618, and combining both created a regression

import yt
from yt.testing import fake_random_ds

ds = fake_random_ds(64, unit_system="code")
p = yt.SlicePlot(ds,"x",("gas", "density"))
p.annotate_timestamp(draw_inset_box=True)
p.save("timestamp.png")

timestamp

@neutrinoceros neutrinoceros added this to the 4.0.3 milestone Mar 29, 2022
@matthewturk matthewturk merged commit 5abe3cf into yt-project:main Mar 30, 2022
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 30, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/yt that referenced this pull request Mar 30, 2022
@matthewturk @meeseeksmachine
Backport PR yt-project#3870: BUG: fix a regression where calling anno…
76921cc 
…tate_timestamp on a plot from a dataset with code units would crash
@neutrinoceros neutrinoceros deleted the hotfix_3869 branch March 30, 2022 10:56
neutrinoceros added a commit that referenced this pull request Mar 30, 2022
@neutrinoceros
Merge pull request #3871 from meeseeksmachine/auto-backport-of-pr-387…
863baf3 
…0-on-yt-4.0.x

Backport PR #3870 on branch yt-4.0.x (BUG: fix a regression where calling annotate_timestamp on a plot from a dataset with code units would crash)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
bug units viz: 2D
Projects
None yet
Milestone
4.0.3
Development

Successfully merging this pull request may close these issues.

BUG: can't use annotate_timestamp with code units
2 participants
@neutrinoceros @matthewturk