-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: setting GeoAxes extent #4040
Conversation
code suggestion Co-authored-by: Clément Robert <cr52@protonmail.com>
So in the latest batch of commits, among other things, I adjusted the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two quick comments, otherwise LGTM
oops, just pushed to this branch accidentally... ignore the latest changes, will fix.... |
c4390ef
to
4f6bbbb
Compare
suggested geoaxes check Co-authored-by: Clément Robert <cr52@protonmail.com>
ok. fixed the accidental push, updated the geoaxes check. and I want to add one more test then this will be good I think! |
I forgot to check that |
3a81b86
to
ad8c7ee
Compare
I fixed the 2 issues (one purely stylistic, reported by flake8) with my latest suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good to go. Before I merge, does this completely fix #4039 (which isn't currently linked) ?
Yes, this does fix the bug there. The other part of the discussion in #4039 (setting the |
BUG: setting GeoAxes extent
This changes how the
extent
for GeoAxes is handled -- this version callsset_extent
only if the data is not global and always passes theextent
kwarg to imshow. Seemed to work well locally, but we'll see how CI does...I may broaden the scope of this PR to include changing the default projection to set theEDIT: Will look into this for a follow up PR.central_longitude
kwarg from the plot arguments when available, but if that proves to be too complex I'll just keep this PR to theextent
modification.