BUG: Fix flux calculation on surface when there is no fluxing_field #4042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Nominally, when one creates a
YTSurface
object usingds.surface
, and then usescalculate_flux
on the object to calculate a flux through the surface, if nofluxing_field
is provided it should default to1.0 dimensionless
. I discovered by accident today that this isn't the case--mainly becausenp.ones_like
now preserves units (see code below). This is the fix for that. The test has been improved to catch it.PR Checklist