BUG: avoid using deprecated matplotlib.cm API #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this and #4076 call for a new bugfix release to make downstream applications more easily testable |
neutrinoceros
force-pushed
the
hotfix_depr_colormap_api
branch
from
3c24e9c
to
ee30e27
Compare
neutrinoceros
commented
Aug 20, 2022
| @@ -8,7 +8,7 @@ | |||
| # Create projections using each colormap available. | |||
| p = yt.ProjectionPlot(ds, "z", "density", weight_field="density", width=0.4) | |||
|
|
|||
| for cmap in cm.datad: | |||
There was a problem hiding this comment.
matplotlib.cm.datad isn't deprecated but it's also not clearly intended to be exposed, as it just happens to be there as a side effect of a re-export, see https://github.com/matplotlib/matplotlib/blob/9b1fcf67c4228c4a2788af5bcaf0c6fde09a55bf/lib/matplotlib/cm.py#L26
so I've replaced it with current API, which would break for old versions of Matplotlib, but I think it's okay to do that in a docs script ?
neutrinoceros
force-pushed
the
hotfix_depr_colormap_api
branch
from
ee30e27
to
638d074
Compare
|
@yt-fido test this please |
This was referenced Aug 20, 2022
brittonsmith
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #4088
running the bleeding edge CI workflow on my fork at https://github.com/neutrinoceros/yt/actions/runs/2894300482