ENH: avoid subclassing builtin dict #4116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
problem
Subclassing builtin types like
dict
is error prone because overriden methods are mostly ignored.This can lead to very subtle bugs where custom classes don't behave as one would expect
outputs
We see that the user-defined
__setitem__
method is correctly used when setting a new value, but is ignored at initialization.solution
subclass
collections.UserDict
instead, which is intended to avoid these subtle issues