Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Arepo stellar photometric fields #4120

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

jzuhone
Copy link
Contributor

@jzuhone jzuhone commented Sep 12, 2022

PR Summary

Arepo has stellar photometric fields representing different stellar magnitudes (defined here). This PR adds them with helpful field name aliases.

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@jzuhone jzuhone added code frontends Things related to specific frontends new feature Something fun and new! labels Sep 12, 2022
matthewturk
matthewturk previously approved these changes Sep 12, 2022
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, my minor suggestion is not necessary

yt/frontends/gadget/io.py Outdated Show resolved Hide resolved
Co-authored-by: Matthew Turk <matthewturk@gmail.com>
@neutrinoceros neutrinoceros merged commit e96dc68 into yt-project:main Sep 13, 2022
@jzuhone jzuhone deleted the stellar_phot branch November 7, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code frontends Things related to specific frontends new feature Something fun and new!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants