-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add API to switch raytracing engine at runtime #4142
ENH: add API to switch raytracing engine at runtime #4142
Conversation
213fde8
to
e4ec1dd
Compare
4461e50
to
65ce6d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@matthewturk I just realised I don't need the boolean flag, give me a minute to remove it and then you can set this to auto-merge if you'd like |
65ce6d3
to
26c3b08
Compare
26c3b08
to
f0a2e04
Compare
Sorry about the additional iterations, I think it's good now. |
sigh... actually I do need it, otherwise my fixtures just crash pytest |
Pull request was converted to draft
Nevermind. This is usable as is, and validated via #4122 |
A problem I failed to see originally here is that
This isn't acceptable.
None of these are ideal. I think 1) is the correct thing to do, provided the breaking change clearly mentioned in release notes. Notes on 1):
Hopefully this feels acceptable not just to me, I'll let reviewers discuss this point. |
f0a2e04
to
efb6c84
Compare
I've now implemented my preferred solution (1) |
PR Summary
This allows to properly define pytest fixtures for switching between "yt" and "embree" ray tracing engine options at runtime (useful in #4122)
Also, a follow up to #3626