BLD: promote ipywidget to a hard dependency #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
bug
infrastructure
|
Note that this leaves #4054 unresolved. The core issue is that we do not distinguish between running within IPython and Jupyter Notebook/Lab |
|
Turns out @cphyc 's previous inquiry already contains the solution to the core problem #4054 (comment) I think this PR may be a correct first step towards resolution of #4054 too, as long as we require ipywidget>=8.0.0 |
|
Actually, it may not even be necessary to require ipywidget since |
cphyc
approved these changes
Oct 10, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Oct 10, 2022
neutrinoceros
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #4154