Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: resolve compatibility with pytest 7.2 #4189

Merged
merged 2 commits into from
Oct 27, 2022
Merged

TST: resolve compatibility with pytest 7.2 #4189

merged 2 commits into from
Oct 27, 2022

Conversation

neutrinoceros
Copy link
Member

PR Summary

Quick fix for #4188

  • TST: configure pytest to ignore test modules using deprecated nose support
  • TST: migrate a test from nose to pytest API

@neutrinoceros neutrinoceros added blocker Highest priority level infrastructure Related to CI, versioning, websites, organizational issues, etc tests: running tests Issues with the test setup labels Oct 25, 2022
@neutrinoceros neutrinoceros added this to the 4.1.2 milestone Oct 25, 2022
@neutrinoceros neutrinoceros added this to todo in nose -> pytest migration via automation Oct 25, 2022
@neutrinoceros neutrinoceros linked an issue Oct 25, 2022 that may be closed by this pull request
TST: CI instability caused by pytest 7.2 #4188
Closed
@neutrinoceros neutrinoceros marked this pull request as ready for review October 25, 2022 16:46
cphyc
cphyc approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@cphyc cphyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'd be happy to have a second pair of eyes to be sure we're not sending tests to /dev/null.

nose -> pytest migration automation moved this from todo to In progress Oct 26, 2022
@neutrinoceros
Copy link
Member Author

I've checked everywhere requires_module_pytest is used and found that all affected tests are still run (yt/tests/test_load_sample.py and yt/tests/test_load_archive.py).

@neutrinoceros neutrinoceros merged commit e1f3fc3 into yt-project:main Oct 27, 2022
nose -> pytest migration automation moved this from In progress to Done Oct 27, 2022
@neutrinoceros neutrinoceros deleted the pytest_7.2_compat branch October 27, 2022 08:13
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 27, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/yt that referenced this pull request Oct 27, 2022
@neutrinoceros @meeseeksmachine
Backport PR yt-project#4189: TST: resolve compatibility with pytest 7.2
344118b
neutrinoceros added a commit that referenced this pull request Oct 27, 2022
@neutrinoceros
Merge pull request #4192 from meeseeksmachine/auto-backport-of-pr-418…
f4de2f6 
…9-on-yt-4.1.x

Backport PR #4189 on branch yt-4.1.x (TST: resolve compatibility with pytest 7.2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cphyc cphyc cphyc approved these changes

Assignees
No one assigned
Labels
blocker Highest priority level infrastructure Related to CI, versioning, websites, organizational issues, etc tests: running tests Issues with the test setup
Projects
nose -> pytest migration
Done
Milestone
4.1.2
Development

Successfully merging this pull request may close these issues.

TST: CI instability caused by pytest 7.2
2 participants
@neutrinoceros @cphyc