Automatically find EWAH files with increased index_order2

[jzuhone]

PR Summary

When loading particle datasets, a morton index is either created and stored to an EWAH file or is loaded from an already existing file.

PR #3198 allowed for the automatic updating of the refined index to be more efficient. However, since both the coarse and the fine index are in the filename, an existing EWAH file with the updated index order is not found and thus the index must be re-generated again.

This PR changes the logic slightly so that EWAH filenames with either the original refined index or the updated one can be found and used.

Closes Issue #3487.

PR Checklist

• New features are documented, with docstrings and narrative docs
• Adds a test for any bugs fixed. Adds tests for new features.

[neutrinoceros]

about the CodeTour watch failure: it might be worth trying bumping this action (current latest is 1.6.3 https://github.com/pozil/codetour-watch/releases)

[matthewturk]

@jzuhone this is awesome and I think will make a lot of lives easier. (cc @chummels )

[neutrinoceros]

I like the idea, and I assume this is hard to test automatically so I guess it's fine as is, provided it can at least be manually validated.

[jzuhone]

@neutrinoceros thanks for the catch on range. I did do some manual testing as well.

[neutrinoceros]

Note that the fix to CodeTour failures is to update https://github.com/yt-project/yt/blob/main/.tours/particle-indexing.tour to match the new line numbers

[jzuhone]

Welp, I updated the line numbers in codetour and updated the hash for the commit it should use and we're still failing

[matthewturk]

@jzuhone I'll take a look

[neutrinoceros]

I tried just bumping the action, to no avail. I don't understand why it's still failing.

[matthewturk]

I'll open it up in codetour and take a look asap

…

On Wed, Nov 9, 2022 at 4:15 AM Clément Robert ***@***.***> wrote: I tried just bumping the action, to no avail. I don't understand why it's still failing. — Reply to this email directly, view it on GitHub <#4198 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAVXOZR3IVFMS2PSD74H4DWHN2THANCNFSM6AAAAAARZPZMVE> . You are receiving this because your review was requested.Message ID: ***@***.***>

[jzuhone]

Some googling of the error message it prints out ("Resource not accessible by integration") suggests some kind of weird permissions problem

[jzuhone]

The test failure here has something to do with a GitHub secret that apparently has a permissions issue. Not sure if I can say much more than that.

[jzuhone]

Is it because I don't have the secret in my fork? I'm not sure why it would fail only on this PR then

[neutrinoceros]

I don't think the problem is with your fork, but with the main repo's configuration (maybe the secret's name is incorrect ?)
We absolutely need a repo owner to look at this, but it seems to me that this workflow never worked properly (apparently it's supposed to write automated comments in the discussion thread).
@matthewturk , if you're not able to fix this soon, I think we should just turn off this workflow for now rather than blocking the next bugfix release over this

[Xarthisius]

Looking at what it want to paste as a comment:

CodeTour Watch

Changed files with possible CodeTour impact:

• yt/geometry/particle_geometry_handler.py

Impacted CodeTour files:

• .tours/particle-indexing.tour

Make sure to review CodeTour files and update line numbers accordingly.

Maybe if we do that it will go away... :) Oh, I see you did that already.

[Xarthisius]

I checked that GITHUB_TOKEN is enabled, and has write permission to issues (everything really). I don't know why it's failing...

[jzuhone]

I filed an issue with the action maintainer

[neutrinoceros]

Thank you for taking a look. I can open a PR to propose we deactivate this workflow as well as an issue to keep track of this, but I won't be able to before a couple hours (if anyone wants to do it before that, feel free to !)

[neutrinoceros]

issue: #4213
and PR: #4214

[neutrinoceros]

Just so this remains 100% relevant to backport, I'll remove my vain commit