STY: upgrade flake8-bugbear and fix newly detected errors #4242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
flake8-bugbear-opinionated
branch
from
dbc64fa
to
e55cc7e
Compare
neutrinoceros
force-pushed
the
flake8-bugbear-opinionated
branch
3 times, most recently
from
c730a30
to
b42cfa7
Compare
…estamp if dataset doesn't have current_redshift
…ess_data (avoid relying on assert in the business logic)
neutrinoceros
force-pushed
the
flake8-bugbear-opinionated
branch
from
c2b7180
to
86162e5
Compare
matthewturk
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Opening as a draft because it's not obvious that adding
@abstractmethoddecorators here and there will not crash testsTODO: