Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add support for installing yt with cherry-picked, frontend specific optional dependencies with pip #4272

Merged
merged 4 commits into from
Dec 29, 2022
Merged

ENH: add support for installing yt with cherry-picked, frontend specific optional dependencies with pip #4272

merged 4 commits into from
Dec 29, 2022

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Dec 28, 2022 •
edited

PR Summary

Fix #4270
I still need to add documentation, but I'm opening as a draft to see how it goes with CI

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • [N/A] Adds a test for any bugs fixed. Adds tests for new features.

@neutrinoceros neutrinoceros added the new feature Something fun and new! label Dec 28, 2022
@neutrinoceros neutrinoceros force-pushed the frontends_req_targets branch 2 times, most recently from 0d2ae9b to 6919a4f Compare December 28, 2022 20:18
matthewturk
matthewturk reviewed Dec 28, 2022
View reviewed changes
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks really well done. I think we should also have the jupyter widgets and widgyts stuff in there as an option some where, and eventually napari.

@neutrinoceros
Copy link
Member Author

sure ! what are the requirements for this, and would you like to suggest a target name (maybe yt[jupyter] fits ?) ?

@neutrinoceros neutrinoceros mentioned this pull request Dec 29, 2022
Closed
@neutrinoceros neutrinoceros marked this pull request as ready for review December 29, 2022 15:06
@neutrinoceros @matthewturk
Update doc/source/installing.rst
8568210 
Co-authored-by: Matthew Turk <matthewturk@gmail.com>
@matthewturk matthewturk merged commit 3ebc61d into yt-project:main Dec 29, 2022
@neutrinoceros neutrinoceros deleted the frontends_req_targets branch December 29, 2022 17:00
@neutrinoceros neutrinoceros mentioned this pull request Jan 8, 2023
Merged
@neutrinoceros neutrinoceros mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
new feature Something fun and new!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: support per-frontend extra requirements with pip
2 participants
@neutrinoceros @matthewturk