ENH: migrate from pkg_resources to importlib.resources on Python 3.9+ #4292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewturk
reviewed
Jan 10, 2023
setupext.py
Outdated
| @@ -205,7 +204,7 @@ def check_for_pyembree(std_libs): | |||
| embree_libs = [] | |||
| embree_aliases = {} | |||
| try: | |||
| _ = resource_filename("pyembree", "rtcore.pxd") | |||
| _ = importlib.resources.files("pyembree") / "rtcore.pxd" | |||
There was a problem hiding this comment.
this doesn't need changes on the pyembree side, right?
There was a problem hiding this comment.
It doesn't. It works exactly like pkg_resources except that it returns a Path object instead of a string.
In hindsight it's completely useless (in both implementations) to look for an exact file like we do here, because both implementations are happy to produce a path to a file even if it's not there (though they do error with ModuleNotFoundError if pyembree isn't installed).
|
Of course the functions I need were not in the standard library before Python 3.9... adding compatibility for Python 3.8 |
neutrinoceros
force-pushed
the
migrate_away_from_pkg_resources
branch
2 times, most recently
from
3c2c896
to
8c32a23
Compare
neutrinoceros
added
enhancement
neutrinoceros
force-pushed
the
migrate_away_from_pkg_resources
branch
2 times, most recently
from
202e6b2
to
71d63ee
Compare
neutrinoceros
changed the title
neutrinoceros
force-pushed
the
migrate_away_from_pkg_resources
branch
from
71d63ee
to
bb4c0ee
Compare
neutrinoceros
changed the title
Xarthisius
reviewed
Jan 13, 2023
Xarthisius
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
fix #4287
Turns out it was super easy, barely an inconvenience.