MAESTROeX uses namespaces for parameters #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes the detection of how temperature is defined
|
Seems pretty straightforward. Does the exact name of this parameter depend on MAESTROeX's version ? |
|
MAESTRO is the old code, written in F90. It is really not used much any more. MAESTROeX is the rewrite in C++, and it uses namespaces for the parameters, hence the change in the parameter name. I don't expect any more changes. |
|
Ok, can you add inline comments to indicate what branch is destined to what code ? |
done |
neutrinoceros
approved these changes
Feb 21, 2023
neutrinoceros
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the detection of how temperature is defined
PR Summary
PR Checklist