-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF: add explicit noexcept qualifiers to resolve perf regressions (Cython 3) #4390
PERF: add explicit noexcept qualifiers to resolve perf regressions (Cython 3) #4390
Conversation
2b0d84c
to
e1719c9
Compare
Am I understanding that our global settings don't propagate to PXD files? |
which global settings ? |
Oh, I thought you tested it with setting the |
Disabling exception handling globally is only possible Cython 3, so we can't do that until we drop Cython 0.29. |
Ah, I understand. I think for some reason I thought we gatekept the opt behind a version check. But this is fine. |
e1719c9
to
45fe031
Compare
pushed a bunch more |
This is not over (performance is still degraded on Cython 3.0.0b2), but we're getting there. I'd prefer to keep my PRs small so I'll wait for this one to be included before I dig further. |
I think one thing that's been slightly unexpected that we're learning here is that some of the |
PR Summary
As tested on my fork, this resolves most of the performance regressions seen in smoke tests with bleeding-edge CI (getting testing airtime from ~17min to ~8 min).
follow up to #4386