RFC: simplify base CoordinateHandler implementation (cached properties) #4435
Conversation
neutrinoceros
force-pushed
the
rfc_simplify_CoordinateHandler
branch
from
e65db54
to
4c5c6ce
Compare
well also even if I wrote them today I didn't know it was in |
| dpj[ax] = None | ||
| self._data_projection = dpj | ||
| return dpj | ||
| return {ax: None for ax in self.axis_order} |
There was a problem hiding this comment.
So this is definitely not a user-facing issue, but from my perspective, I am wondering -- is it possible to invalidate the cached property at runtime?
There was a problem hiding this comment.
The result of a cached_property can be mutated transparently. Does this answer your question ?
There was a problem hiding this comment.
Oh I guess you were wondering if it was possible to reset the property to its initial state.
In which case the answer is: not to my knowledge
There was a problem hiding this comment.
... and a better answer yet, from the docs:
The cached value can be cleared by deleting the attribute. This allows the cached_property method to run again.
PR Summary
Some low-hanging simplifications I found while working on #4179
functools.cached_propertywasn't available before Python 3.8 which explains why these properties didn't use it already.As a side bonus, I also discovered and replaced two occurrences of
abc.abstractproperty, which is deprecated since Python 3.3