-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: simplify cartopy integration testing (using cartopy 0.22) #4621
TST: simplify cartopy integration testing (using cartopy 0.22) #4621
Conversation
8ecc8bb
to
fed64eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ci_install.sh
script was still installing geos -- which we shouldn't have to do anymore. I left comments pointing out those spots as well as a couple other further simplifications that I think are possible.
Also, adding cartopy>=0.22 as a proper dependency in yt[full]
would further simplify the setup here. Thoughts on that?
yes, that is also what I assumed at first but unfortunately geos is still needed to build
this was also one of my goals for this PR but given how shapely is still a pain to install (the source distribution from PyPI doesn't build on Windows), I renounced that goal too; |
Oh huh, that's a shame... I think all my comments can be disregarded in that case. |
I checked, and I think the title of this PR says it all |
Looking more carefully at shapely -- they do package geos. Did you try removing the geos install from the Ubuntu and Mac branch of the install script? |
But the shapely docs make it pretty clear that you should only need to install geos explicitly if you want a specific version https://shapely.readthedocs.io/en/latest/installation.html maybe that's not the case in practice |
ah ! Let's try not to build shapely from source then: it doesn't seem to be recommended any more by cartopy, and I assume it would save us installing geos too |
Looks like it worked ! thank you for spotting this Chris, I will iterate a little more and then reopen for review |
0f4c90a
to
afb2b23
Compare
afb2b23
to
06cb019
Compare
Note that wheels are only available for Python 3.9 and above. I don't think this is blocking here, but that's a sign that supporting Python 3.8 is becoming harder for us. |
Another note: I think this works makes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! And removing conda if possible in a later pr makes sense to me.
Cartopy 0.22 was just released and is supposed to resolve a couple workarounds we've been using to test it.
Most notably, this version doesn't depend on GEOS, and as such, it can afford to have wheels, which should allow us to properly test it on all platforms for cheap !