ENH: Only call find_spec sometimes #4640
Conversation
| if display_array and find_spec("ipywidgets") is not None: | ||
| self.display_array = True | ||
| else: | ||
| self.display_array = False |
There was a problem hiding this comment.
I have a small preference for the one-liner form, but it's not crucial (I've checked that it is black-compliant)
| if display_array and find_spec("ipywidgets") is not None: | |
| self.display_array = True | |
| else: | |
| self.display_array = False | |
| self.display_array = display_array and find_spec("ipywidgets") is not None |
Note that this isn't 100% true: it is possible to install a package at runtime using |
|
Yeah, I know it's not strictly true, but it's true enough. We shouldn't bother catching it. |
|
agreed |
|
for a bit of extra context: we found that this |
|
Moving this to 4.2.2 upon @matthewturk's request |
In some cases, particularly when instantiating lots of child masks, the way the
MutableAttributeobject is set up could lead tofind_specbeing called inside some tight loops.But, the results of
find_specshouldn't change during the course of one interpreter's existence. So we can move the checks to the outside of the__get__call, which reduces costs of grid indexing considerable in some cases.