BUG: load_hdf5_file doesn't pass bounding box to load_amr_grids #4672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewturk
previously approved these changes
Sep 20, 2023
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
@yt-fido test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
load_hdf5_fileserves as a way to load arbitrary HDF5 files with the stream frontend as a wrapper aroundload_amr_grids. It accepts a bounding box argumentbboxthat can be used to determine the grid decomposition, but this bounding box is not passed toload_amr_gridsitself and therefore the actual bounding box does not change. This PR addresses that issue and provides a test.PR Checklist