Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: fix load_sample with no arguments #4693

Merged
merged 3 commits into from
Oct 9, 2023
Merged

BUG: fix load_sample with no arguments #4693

merged 3 commits into from
Oct 9, 2023

Conversation

chrishavlin
Copy link
Contributor

Closes #4691

Was easiest to just move the check for fn is None out of _get_sample_data to the main load_sample. Also added a minimal test.

@chrishavlin chrishavlin added the bug label Oct 9, 2023
neutrinoceros
neutrinoceros approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you !

@neutrinoceros neutrinoceros added this to the 4.3.0 milestone Oct 9, 2023
@neutrinoceros neutrinoceros merged commit e318e88 into yt-project:main Oct 9, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neutrinoceros neutrinoceros neutrinoceros approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

BUG: calling yt.load_sample with no arguments is broken on main
2 participants
@chrishavlin @neutrinoceros