BUG: handle deprecation warnings from numpy 2.0.0dev0 (np.row_stack -> np.vstack and np.in1d -> np.isin) #4725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…> np.vstack and np.in1d -> np.isin)
matthewturk
reviewed
Nov 2, 2023
| @@ -99,9 +99,9 @@ def __init__( | |||
| ): | |||
| dd = ds.all_data() | |||
| newtags = dd[fds["particle_index"]].d.astype("int64") | |||
| mask = np.in1d(newtags, indices, assume_unique=True) | |||
| mask = np.isin(newtags, indices, assume_unique=True) | |||
There was a problem hiding this comment.
is the returned shape the same?
There was a problem hiding this comment.
yes. It matches the shape of the first argument in both cases.
matthewturk
approved these changes
Nov 2, 2023
|
It is ! I removed the draft status as soon as I saw that tests passed everywhere :) |
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Nov 2, 2023
…mpy 2.0.0dev0 (np.row_stack -> np.vstack and np.in1d -> np.isin)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix remaining usage of deprecated API. See https://numpy.org/devdocs/release/2.0.0-notes.html#deprecations