BUG: avoid a noisy self-triggered warning about libconf being a hard dependency to load any enzo data #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependency to load any enzo data
chrishavlin
approved these changes
Nov 20, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Nov 22, 2023
…g about libconf being a hard dependency to load any enzo data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
similar to #4708, follow up to #4275
The issue here is that
EnzoDatasetis used for Enzo 2 and Enzo 3 data, butlibconfis only required with the latter, so warning aboutlibconfnot being installed is just noisy when working with Enzo 2 data (including everyone's favourite dataset, IsolatedGalaxy).