ENH: add support for Quokka datasets #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quokka doesn't have a job_info file, but does have a metadata.yaml file (containing an empty mapping by default).
neutrinoceros
added
code frontends
neutrinoceros
approved these changes
Feb 5, 2024
matthewturk
approved these changes
Feb 8, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Feb 8, 2024
neutrinoceros
added a commit
that referenced
this pull request
Feb 8, 2024
…5-on-yt-4.3.x Backport PR #4805 on branch yt-4.3.x (ENH: add support for Quokka datasets)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This allows yt to recognize Quokka output files. They are handled by the AMReX reader, but the reader does not recognize the particle data when loading Quokka outputs using
yt.load. (Manually creating anAMReXDatasetobject does work, but this should not be necessary for users to invoke directly.)Unlike other AMReX/Boxlib codes, Quokka doesn't have a
job_infofile, but does have ametadata.yamlfile (which may be empty). This PR detects this file, and this causes reader to then recognize any particle data that may be present.Thanks to @BenWibking for noticing this and providing sample outputs!
PR Checklist