BUG: Assign domain dims after updates in Athena

[matthewturk]

As reported on the mailing list, in 2D athena datasets we can't modify the domain_dimensions (which are a MutableAttribute) after setting them. So, we hold off on setting them until after we do the dimensionality updates.

[neutrinoceros]

Having a hard time understanding how this wasn't caught earlier but otherwise LGTM !

[neutrinoceros]

(I don't remember what the "backport-stable" label is suppose to do but I'm sure it's not how we've been doing backports lately. I've set the milestone to backport to 4.3.x)

[matthewturk]

@neutrinoceros thanks, I wasn't sure!

I think because we don't test 1 or 2D athena datasets we didn't catch it. Mocking them would help, but is likely extremely difficult to set up.

The thing about MutableAttribute, to my reading, is that it generally could provide us a lot of being able to avoid conversions etc, but we don't yet take advantage of it. I think in one of the optimization PRs I tried to. I should return to that.

[neutrinoceros]

Blocked by #4814

[jzuhone]

@yt-fido test this please

[jzuhone]

@yt-fido test this please

[cphyc]

The failing tests are unrelated and fixed in #4819.

[neutrinoceros]

This is blocked by an unresponsive bot. Can we put it to sleep ?

[matthewturk]

Yes

[wkal2]

Hi all, Many thanks for your attention to the domain dimensions issue I have! After trying the pull request, I have however encountered another error, which I have quoted below

Traceback (most recent call last):
File "/home/wkal2/rds/hpc-work/project/code/plot_full_output.py", line 17, in
ds = yt.load(vtk_filename,parameters=parameters)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/wkal2/yt/yt/_maintenance/deprecation.py", line 69, in inner
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/home/wkal2/yt/yt/loaders.py", line 145, in load
return cls(fn, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/wkal2/yt/yt/frontends/athena/data_structures.py", line 502, in init
self.index
File "/home/wkal2/yt/yt/data_objects/static_output.py", line 606, in index
self._instantiated_index = self._index_class(
^^^^^^^^^^^^^^^^^^
File "/home/wkal2/yt/yt/frontends/athena/data_structures.py", line 134, in init
GridIndex.init(self, ds, dataset_type)
File "/home/wkal2/yt/yt/geometry/geometry_handler.py", line 39, in init
self._setup_geometry()
File "/home/wkal2/yt/yt/geometry/grid_geometry_handler.py", line 41, in _setup_geometry
self._parse_index()
File "/home/wkal2/yt/yt/frontends/athena/data_structures.py", line 335, in _parse_index
self.dataset.domain_dimensions[2] = 1
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
ValueError: assignment destination is read-only
Exception ignored in: <function GridIndex.del at 0x14f7824e3420>
Traceback (most recent call last):
File "/home/wkal2/yt/yt/geometry/grid_geometry_handler.py", line 67, in del
del self.grids
^^^^^^^^^^
AttributeError: 'AthenaHierarchy' object has no attribute 'grids'

So sorry if you have already received this message on other platforms and really appreciate your help and assistance thus far, do let me know if there is anything I could do on my part!

[matthewturk]

@wkal2 I've updated the PR with a slightly different change. Can you try this?

[wkal2]

Thanks! Just tried to run the code again but this time there is a module error

Traceback (most recent call last):
File "/home/wkal2/rds/hpc-work/project/code/plot_full_output.py", line 8, in
import yt
File "/home/wkal2/yt/yt/init.py", line 14, in
from yt.data_objects.api import (
File "/home/wkal2/yt/yt/data_objects/api.py", line 1, in
from . import construction_data_containers as __cdc, selection_objects as __sdc
File "/home/wkal2/yt/yt/data_objects/construction_data_containers.py", line 17, in
from yt.data_objects.selection_objects.data_selection_objects import (
File "/home/wkal2/yt/yt/data_objects/selection_objects/init.py", line 1, in
from .boolean_operations import (
File "/home/wkal2/yt/yt/data_objects/selection_objects/boolean_operations.py", line 5, in
from yt.data_objects.selection_objects.data_selection_objects import (
File "/home/wkal2/yt/yt/data_objects/selection_objects/data_selection_objects.py", line 14, in
from yt.data_objects.data_containers import YTDataContainer
File "/home/wkal2/yt/yt/data_objects/data_containers.py", line 13, in
from yt.data_objects.profiles import create_profile
File "/home/wkal2/yt/yt/data_objects/profiles.py", line 5, in
from yt.fields.derived_field import DerivedField
File "/home/wkal2/yt/yt/fields/derived_field.py", line 18, in
from .field_detector import FieldDetector
File "/home/wkal2/yt/yt/fields/field_detector.py", line 7, in
from yt.utilities.io_handler import io_registry
File "/home/wkal2/yt/yt/utilities/io_handler.py", line 10, in
from yt.geometry.selection_routines import GridSelector
ModuleNotFoundError: No module named 'yt.geometry.selection_routines'

[matthewturk]

That looks unrelated, and is usually because you need to recompile the yt compiled bits.

[wkal2]

My bad, it is working now, thank you so much!

[chrishavlin]

This looks good to merge, ya? @neutrinoceros and @matthewturk