CLN: remove untested and broken notebook command from CLI #4835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewturk
previously approved these changes
Feb 27, 2024
neutrinoceros
force-pushed
the
cln/remove_broken_yt_notebook
branch
from
570f0c0
to
0219c1a
Compare
|
@matthewturk actually, maybe this could be backported, what do you think ? |
chrishavlin
approved these changes
Mar 4, 2024
|
@yt-fido test this please |
|
Is this one waiting on anything? @matthewturk you ok with backporting (see @neutrinoceros's comment above)? IMO it's fine to backport. |
|
lgtm on both accounts |
|
alrighty let's get it moving then. Thank you both ! |
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Mar 28, 2024
… command from CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In response to this post on the mailing list.
The command is untested, broken, and obsolete, so let's just retire it to avoid further confusion.