Bug: fix geographic coordinate conversions

[chrishavlin]

The latitude to theta conversion (EDIT: as well as the longitude to phi and to convert_to_cartesian method) in the geographic coordinate handlers was incorrect in a number of locations. I added a new test and parametrized the existing geographic coordinate tests while I was there.

[matthewturk]

Can you verify this matches what's in the docs?

[chrishavlin]

Just took a look through the docs and I can't find any mention of latitude/theta conversion. There are some scattered comments related to the aitoff projection that mention e.g., "latitude is -PI/2 to PI/2 (latitude = PI/2 - colatitude)", but I don't see any user-facing docs that do.

Checking on that prompted me to look at longitude as well and I realized the _longitude_to_phi function has an error as well... going to push up a fix in a moment.

[chrishavlin]

@yt-fido test this please

[chrishavlin]

@yt-fido test this please

[neutrinoceros]

@yt-fido test this please

[chrishavlin]

pre-commit.ci autofix

[chrishavlin]

Assuming tests still pass, this should be good to go. @matthewturk any more comments here?

[chrishavlin]

@yt-fido test this please

[chrishavlin]

@yt-fido test this please

[neutrinoceros]

@matthewturk are you able to take another look ? I may be able to fill in as a reviewer otherwise.

[chrishavlin]

@neutrinoceros I checked in w Matt, he'll be able to take another look soon

[matthewturk]

This is great.

[neutrinoceros]

thanks all !

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout yt-4.3.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 24736e144bd573bf170fd183944caf6f8129f2cc

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #4839: Bug: fix geographic coordinate conversions'

4. Push to a named branch:

git push YOURFORK yt-4.3.x:auto-backport-of-pr-4839-on-yt-4.3.x

5. Create a PR against branch yt-4.3.x, I would have named this PR:

"Backport PR #4839 on branch yt-4.3.x (Bug: fix geographic coordinate conversions)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.